Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify how to create Dockerfile and how to build #34

Merged
merged 1 commit into from
May 18, 2020

Conversation

StefanScherer
Copy link
Member

This PR adds more details to clarify where to create the Dockerfile and where to go to run the first docker build command.

I also struggled a bit in Play with Docker as I had the tutorial and PWD in two browser windows side-by-side and then the left bar in PWD disappeared.

Fixes #29

Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>
Copy link
Member

@mikesir87 mikesir87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikesir87 mikesir87 merged commit 6652785 into docker:master May 18, 2020
@StefanScherer StefanScherer deleted the add-instructions branch May 18, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unclear instructions, hard to start, where to create Dockerfile, how to set the docker working directory
2 participants