Parse raw certificate subjects before debug logging #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why do we even do all work that for a debug log? If we really really want to log those names, can we run that code only if debugging is enabled? |
|
Agreed! I concur that we could run this code only if debugging is enabled, though we could also just change the debug log to output the number of trusted certificates ( I'll work on the former, but let me know if you prefer a different way forward :) |
|
either of those options sounds good to me. |
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
riyazdf
force-pushed
the
subject-debug-log
branch
from
7795a28
to
2793168
Compare
|
@calavera I think the number of certs is much cleaner, so I've updated the debug log accordingly |
|
awesome, thanks! Merging 🎉 |
calavera
added a commit
that referenced
this pull request
Mar 4, 2016
Parse raw certificate subjects before debug logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initializing the certificate pool, it would be helpful to print the parsed
pkix.Nameto debug logs instead of the raw DER bytes (example of previous output here: notaryproject/notary#611)Signed-off-by: Riyaz Faizullabhoy riyaz.faizullabhoy@docker.com