Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove punctuation at the end of 2 error strings to fix lint #34

Closed
wants to merge 1 commit into from
Closed

Remove punctuation at the end of 2 error strings to fix lint #34

wants to merge 1 commit into from

Conversation

cyli
Copy link
Contributor

@cyli cyli commented Mar 2, 2017

Master has been failing with the following:

nat/parse.go:36:27: error strings should not be capitalized or end with punctuation or a newline
tlsconfig/config.go:166:26: error strings should not be capitalized or end with punctuation or a newline

All of the errors we return seem to be capitalized, and somehow that doesn't trigger the lint errors despite it saying that error strings should not be capitalized, so it seems like punctation that's the problem.

Alternately if we wanted to lower-case all of these errors I'll be happy to do that too.

Signed-off-by: cyli <cyli@twistedmatrix.com>
@aaronlehmann
Copy link

I would lower-case the errors and reformat them so they are not written in sentence form. For the second error message, I think the ideal solution would be to check somehow for an encrypted key and have a specific error message for that case, but otherwise we could change it to something like error reading X509 key pair - make sure the key is not encrypted (cert: %q, key: %q): %v.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants