Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CI failure #47

Merged
merged 1 commit into from
Feb 2, 2018
Merged

fix CI failure #47

merged 1 commit into from
Feb 2, 2018

Conversation

AkihiroSuda
Copy link
Collaborator

Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp

suda@ws01:~/gopath/src/github.com/docker/go-connections⟫ go vet ./...    
tlsconfig/config_test.go:304: no formatting directive in Fatalf call     
tlsconfig/config_test.go:323: no formatting directive in Fatalf call     
exit status 1                       
1 suda@ws01:~/gopath/src/github.com/docker/go-connections⟫ test -z "$(golint ./... | tee /dev/stderr)"                                            
nat/parse.go:36:27: error strings should not be capitalized or end with punctuation or a newline                                                  
tlsconfig/config.go:240:26: error strings should not be capitalized or end with punctuation or a newline                                          
1 suda@ws01:~/gopath/src/github.com/docker/go-connections⟫ test -z "$(gofmt -s -l . | tee /dev/stderr)"                                           
proxy/udp_proxy.go                  
tlsconfig/certpool_other.go         
1 suda@ws01:~/gopath/src/github.com/docker/go-connections⟫ 

Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

@vdemeester vdemeester merged commit 46f8e42 into docker:master Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants