Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue-56 fix incorrect SortPortMap behaviour in case of empty binding #57

Merged
merged 1 commit into from
Apr 21, 2019
Merged

issue-56 fix incorrect SortPortMap behaviour in case of empty binding #57

merged 1 commit into from
Apr 21, 2019

Conversation

besolov
Copy link
Contributor

@besolov besolov commented Jan 12, 2019

Sample Pull request with patch for #56 issue

@besolov besolov mentioned this pull request Jan 12, 2019
Closed
@besolov
issue-56 fix incorrect SortPortMap behaviour in case of empty binding
9885905 
Signed-off-by: Roman Besolov <roman.besolov@gmail.com>
@besolov
Copy link
Contributor Author

besolov commented Jan 13, 2019

Signed off commit.

@AkihiroSuda
Copy link
Collaborator

cc @thaJeztah

thaJeztah
thaJeztah approved these changes Apr 21, 2019
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 5b033ed into docker:master Apr 21, 2019
@thaJeztah
Copy link
Member

Thanks! Are you planning to update the vendored version in moby/moby?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@besolov @AkihiroSuda @thaJeztah