Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tlsconfig: remove support for tls.VersionSSL30 #66

Closed
wants to merge 1 commit into from

Conversation

alrs
Copy link
Contributor

@alrs alrs commented Nov 8, 2019

The Go authors deprecated support for SSLv3 in go 1.13. They've decided to remove it in go 1.14, and have already merged the commit.

See: https://golang.org/issue/32716

This PR, or something like it, should probably land before February 2020.

@AkihiroSuda
Copy link
Collaborator

CI failure seems unrelated?

#!/bin/bash -eo pipefail
go get -d github.com/Microsoft/go-winio &&
go build ./...
# golang.org/x/sys/windows
/home/circleci/.go_workspace/src/golang.org/x/sys/windows/dll_windows.go:21:6: missing function body for "syscall_loadlibrary"
/home/circleci/.go_workspace/src/golang.org/x/sys/windows/dll_windows.go:24:6: missing function body for "syscall_getprocaddress"
Exited with code 2

@AkihiroSuda
Copy link
Collaborator

commit needs sign

@alrs
Copy link
Contributor Author

alrs commented Nov 8, 2019

@AkihiroSuda I see my commit as signed, is your comment addressed to me?

@AkihiroSuda
Copy link
Collaborator

@alrs alrs closed this Nov 8, 2019
@alrs alrs deleted the increase-minimum-tls branch November 8, 2019 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants