Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitignore #71

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Add .gitignore #71

merged 1 commit into from
Jun 4, 2020

Conversation

thaJeztah
Copy link
Member

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@SamWhited
Copy link
Contributor

SamWhited commented Jun 3, 2020

I personally don't like to gitignore .*, it just leads to a ton of exceptions over time. YMMV though and it doesn't really matter, so LGTM.

@thaJeztah
Copy link
Member Author

I personally don't like to gitignore .*, it just leads to a ton of exceptions over time. YMMV though and it doesn't really matter, so LGTM.

This was after some feedback from @AkihiroSuda in another repository; basically that most hidden files are not something we need in the repository, so this would "catch" most IDE/editor/personalization files. I'm open to better suggestions though 👍

@SamWhited
Copy link
Contributor

Yah, totally up to you, I probably have a pretty minority view here. I generally just think editor files need to be in system level gitignores and not in individual repos, but I do understand that people will insist on git commit -a and we'll have to weed them out in code review

Copy link
Contributor

@tiborvass tiborvass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also not used to .* but okay.

@tiborvass tiborvass merged commit 7662df5 into docker:master Jun 4, 2020
@thaJeztah thaJeztah deleted the add_gitignore branch June 4, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants