-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support both square brackets and raw syntax for IPV6 #78
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Argh.. #77 still isn't merged yet I see, so tests don't actually run 🙄 |
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Thanks! all tests now ran, and passed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
as discovered on docker-archive/compose-cli#1386:
docker-compose (docker-py) uses raw IPv6 for port specification, which go-connections reject as it relies on net.SplitHostPort which require square bracets.
This PR relax requirement for square bracket, while still supporting those. I'll prepare another PR on docker-py to accepts and ignore square brackets, so both can be interoperable.
this is required to let IPV6 users (our own @chris-crone might not be the sole one) switch between docker-compose to dockercompose