Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

daemon log filled with misleading and unwanted 'error' messages #126

Closed
andybrown668 opened this issue Aug 27, 2020 · 0 comments · Fixed by #130
Closed

daemon log filled with misleading and unwanted 'error' messages #126

andybrown668 opened this issue Aug 27, 2020 · 0 comments · Fixed by #130

Comments

@andybrown668
Copy link

when using any (?) docker volume plugin, the log fills with 'error' messages that look like they should only appear if debug logging is switched on.

To reproduce, create a volume using a volume plugin driver, then 'docker volume ls'. The daemon log then contains entries like:
Aug 27 11:14:38 devbox-abrown dockerd[1377]: time="2020-08-27T11:14:38+01:00" level=error msg="2020/08/27 10:14:38 Entering go-plugins-helpers listPath" plugin=92034db972fb311ad75127fa303df5a883cb74c49888261685901010a62f3b83 Aug 27 11:14:38 devbox-abrown dockerd[1377]: time="2020-08-27T11:14:38+01:00" level=error msg="Entering go-plugins-helpers listPath" plugin=a7e9752bd4e70c6072280ea2a61722d0807b1bb65a7cbc5f1694438df609a130 Aug 27 11:14:38 devbox-abrown dockerd[1377]: time="2020-08-27T11:14:38+01:00" level=error msg="Entering go-plugins-helpers listPath" plugin=b197b28a70524c5c58965f8200e14efb8f8c3a97090c77314c742fac6e07dee8 Aug 27 11:14:38 devbox-abrown dockerd[1377]: time="2020-08-27T11:14:38+01:00" level=error msg="2020/08/27 10:14:38 Entering go-plugins-helpers capabilitiesPath" plugin=92034db972fb311ad75127fa303df5a883cb74c49888261685901010a62f3b83
Looking at the plugin helper code I see where the messages originate:

go-plugins-helpers/volume/api.go

Line 133 in c9a8a2d

log.Println("Entering go-plugins-helpers createPath")

It's not clear why they show up as errors, and I'd like to stop them being sent to the log anyway; our swarm nodes are producing 2 million of these a week
andybrown668 added a commit to BlueArchive/docker-volume-plugins that referenced this issue Aug 27, 2020
@andybrown668
fix GEN2-843: removed verbose logging
0753172 
this change replaces the docker go-plugins-helpers with a forked
version; we can revert this when they fix issue
docker/go-plugins-helpers#126
StudioEtrange added a commit to StudioEtrange/go-plugins-helpers that referenced this issue Nov 27, 2020
@StudioEtrange
remove spamming log which wrongly output as an error - same fix than B…
564bfac 
…lueArchive@463fc38 - until upstream fix docker#126
ivandeex added a commit to ivandeex/go-plugins-helpers that referenced this issue May 29, 2021
@ivandeex
Put trace logging under control
d703c47 
This change allows to prevent spamming system logs
Fixes docker#126
@ivandeex ivandeex mentioned this issue May 30, 2021
Merged
ivandeex added a commit to ivandeex/go-plugins-helpers that referenced this issue May 30, 2021
@ivandeex
Put trace logging under control
e819e52 
This change allows to prevent spamming system logs.

Implements docker#130
Fixes docker#126

Signed-off-by: Ivan Andreev <ivandeex@gmail.com>
ivandeex added a commit to ivandeex/go-plugins-helpers that referenced this issue May 30, 2021
@ivandeex
Put trace logging under control
44cdc41 
This change allows plugin authors to disable API trace logging at will. By default it is enabled for backwards compatibility. See docker#130 for details.

Implements docker#130
Fixes docker#126

Signed-off-by: Ivan Andreev <ivandeex@gmail.com>
ivandeex added a commit to ivandeex/go-plugins-helpers that referenced this issue Jun 1, 2021
@ivandeex
Remove API trace logging
4148cf4 
Implements docker#130
Fixes docker#126

Signed-off-by: Ivan Andreev <ivandeex@gmail.com>
thaJeztah pushed a commit to ivandeex/go-plugins-helpers that referenced this issue Dec 24, 2021
@ivandeex @thaJeztah
Remove API trace logging
c221e7d 
Implements docker#130
Fixes docker#126

Signed-off-by: Ivan Andreev <ivandeex@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Put trace logging under control ivandeex/go-plugins-helpers
1 participant
@andybrown668