Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem of #1747 occurs again #1805

Closed
uweplonus opened this issue May 2, 2019 · 21 comments
Closed

Problem of #1747 occurs again #1805

uweplonus opened this issue May 2, 2019 · 21 comments

Comments

@uweplonus
Copy link

uweplonus commented May 2, 2019

Problem description

Specifically, angle bracketed ("<") code inside a "code block" is not rendering properly.

For example, the following will not render on hub.docker.com...

script.sh --parameter1 <your parameter>

This seems to be a regression of #1747

@meticulous-dft
Copy link

Yes, this is a regression. We will fix this early next week.

@wader
Copy link

wader commented May 6, 2019

I see similar issue with & being render escaped as &amp; but looks ok on github. Example markdown file https://hub.docker.com/r/mwader/ydls/

@wader
Copy link

wader commented May 14, 2019

Seems to work now 👍

@demizer
Copy link

demizer commented May 14, 2019

It's still broken for https://hub.docker.com/r/nvidia/cuda, I am going to remove the angle brackets for now so the description renders properly. It seems to not matter if the angle brackets are in a code block or not. Here is where rendering failed in this case:

NVIDIA_REQUIRE_CUDA="cuda>=10.0 brand=tesla,driver>=384,driver<385"

@pedroferreira84
Copy link

@pedroferreira84
Copy link

Any developments about this problem?

@meticulous-dft
Copy link

Hey @pedroferreira84 Can you point to me specifically which part of text in each of these repos do not render correctly? This would help me a lot to track down the problem. Thanks.

@pedroferreira84
Copy link

pedroferreira84 commented Jun 7, 2019

Sure @meticulous-dft!!

Can't I upload files here to show you the errors? Even here is rendering badly...

@pedroferreira84
Copy link

Problem persists....

@meticulous-dft
Copy link

Hi @pedroferreira84 the problem is <> is considered by our parser as html tag, and might add close tag </...> or strip it <input >.

I am working on fix the parsing issue. In the mean time, is it possible for you to use some other symbols instead of <> for placeholder?

@pedroferreira84
Copy link

Dear @meticulous-dft I prefer to wait for you to fix this, as we have other README.md from other Docker images that have those characters "<>" and the problem don't happen.

@pedroferreira84
Copy link

On this Docker image for example: https://hub.docker.com/r/pegi3s/utilities/ is impossible to use other symbols instead of "<,>" because it's an example of a test case file...

@pedroferreira84
Copy link

@meticulous-dft any developments on the parser issue? Still facing the problem here...

@TimWolla
Copy link

TimWolla commented Jul 10, 2019

The second code block of the “Loading Plugins” section of Adminer is affected as well. For that one the opening <?php tag is treated as an HTML tag: https://hub.docker.com/_/adminer/#loading-plugins

@pedroferreira84
Copy link

Dear @meticulous-dft I prefer to wait for you to fix this, as we have other README.md from other Docker images that have those characters "<>" and the problem don't happen.

Dear @meticulous-dft any developments on this matter? It's been a while since this problem persists...

Thank you.

@meticulous-dft
Copy link

@pedroferreira84 Sorry, it takes us a while to figure out how to correct this. I believe it is rendering correct now. Please take a look.

@pedroferreira84
Copy link

@pedroferreira84 Sorry, it takes us a while to figure out how to correct this. I believe it is rendering correct now. Please take a look.

Thank you very much!! :) It's everything OK now!
Best regards,
Pedro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants