-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repository links do not work/trigger #518
Comments
Repository links currently only works on non-regex build rules, because we don't want to blindly go out and rebuild all your Github branches. (Rather, we're coming up with a better way to do that. Would like to know what you think is the right behaviour here.) So if you have repo B linked to an upstream repo A, and repo B only has regex build rules, then those are not going to trigger. If you'd like, give me the repo names and I can go take a look. Thanks! |
Ah, that makes sense! Repos in question: Which are backed by this github repo: I currently have the following build settings set up
This allows me to achieve my use-case like so:
The whole thing works pretty well at the moment except for:
|
I'm experiencing this problem as well. I've got this repository configured as follows: So if I understand correctly, whenever changes are pushed for the What am I doing wrong? |
Hey @bcwalrus, I believe the following repo conforms to your requirements but still does not trigger builds. Am I missing something or is this functionality broken? |
Anyone from the docker team able to comment on if repository links work at all? @mghazizadeh @marcusmartins @akshayvyas |
@bcwalrus Just like tbenst, I have repos without regex build rules [1-2] that are not updated [1] https://hub.docker.com/r/nlpbox/python-zpar/ |
Well this is annoying, any update to this issue docker team???? |
Thanks for the feedback. To clarify, when a repository link is added to an (automated) repository in Hub, it will automatically trigger a rebuild only if the linked repository is also included in the FROM line of your dockerfile. We'll make sure to update the UI to clarify this behavior. |
Automated builds work when Dockerfile is modified after checkout. Otherwise they are not triggered [1]. [1] docker/hub-feedback#518 Change-Id: I6ba9e06f9e62011d2f1c1788f2647b1175842ef3 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
* Update docs/submodules/functest from branch 'master' - Merge "Switch to Docker post_checkout hooks" - Switch to Docker post_checkout hooks Automated builds work when Dockerfile is modified after checkout. Otherwise they are not triggered [1]. [1] docker/hub-feedback#518 Change-Id: I6ba9e06f9e62011d2f1c1788f2647b1175842ef3 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
@pkennedyr Thanks. I ran into a similar issue where building of linked repo would not trigger a build of the other repo. I wasn't using regexes of any kind. The only mistake I had made was not have the FROM line match the name from the automated build. I am not sure if this is documented somewhere, I didn't find it. |
@pkennedyr it does not work. I've linked https://hub.docker.com/r/shoeper/latex/~/dockerfile/ which uses FROM debian:testing to debian and debian:testing got updated two days ago but my automated build has not been updated, nor queued. Same issue with https://hub.docker.com/r/shoeper/chkrootkit/~/dockerfile/ (only uses another tag, which has also been updated) and https://hub.docker.com/r/shoeper/git/~/dockerfile/ and https://hub.docker.com/r/shoeper/spellcheck/~/dockerfile/ All builds do not use regex. |
Looks much like this security issue has not been taken care of for almost three years now. Security issue because e.g. if debian gets a security update and the image is rebuild and people rely on repository linking their image won't be updated and thus will still have the vulnerable libraries. Having a look at docker hub such a scenario is very common. |
I have tried the following:
The text was updated successfully, but these errors were encountered: