update: remove unreachable code

pkg/hub/client.go

@@ -43,7 +43,7 @@ const (
 	itemsPerPage = 100
 )
 
-//Client sends authenticated calls to the Hub API
+// Client sends authenticated calls to the Hub API
 type Client struct {
 	AuthConfig types.AuthConfig
 	Ctx        context.Context
@@ -75,13 +75,13 @@ type tokenResponse struct {
 	RefreshToken string `json:"refresh_token"`
 }
 
-//ClientOp represents an option given to NewClient constructor to customize client behavior.
+// ClientOp represents an option given to NewClient constructor to customize client behavior.
 type ClientOp func(*Client) error
 
-//RequestOp represents an option to customize the request sent to the Hub API
+// RequestOp represents an option to customize the request sent to the Hub API
 type RequestOp func(r *http.Request) error
 
-//NewClient logs the user to the hub and returns a client which can send authenticated requests
+// NewClient logs the user to the hub and returns a client which can send authenticated requests
 // to the Hub API
 func NewClient(ops ...ClientOp) (*Client, error) {
 	hubInstance := getInstance()
@@ -99,7 +99,7 @@ func NewClient(ops ...ClientOp) (*Client, error) {
 	return client, nil
 }
 
-//Update changes client behavior using ClientOp
+// Update changes client behavior using ClientOp
 func (c *Client) Update(ops ...ClientOp) error {
 	for _, op := range ops {
 		if err := op(c); err != nil {
@@ -109,31 +109,31 @@ func (c *Client) Update(ops ...ClientOp) error {
 	return nil
 }
 
-//WithAllElements makes the client fetch all the elements it can find, enabling pagination.
+// WithAllElements makes the client fetch all the elements it can find, enabling pagination.
 func WithAllElements() ClientOp {
 	return func(c *Client) error {
 		c.fetchAllElements = true
 		return nil
 	}
 }
 
-//WithContext set the client context
+// WithContext set the client context
 func WithContext(ctx context.Context) ClientOp {
 	return func(c *Client) error {
 		c.Ctx = ctx
 		return nil
 	}
 }
 
-//WithInStream sets the input stream
+// WithInStream sets the input stream
 func WithInStream(in io.Reader) ClientOp {
 	return func(c *Client) error {
 		c.in = in
 		return nil
 	}
 }
 
-//WithOutStream sets the output stream
+// WithOutStream sets the output stream
 func WithOutStream(out io.Writer) ClientOp {
 	return func(c *Client) error {
 		c.out = out
@@ -189,7 +189,7 @@ func withHubToken(token string) RequestOp {
 	}
 }
 
-//WithSortingOrder adds a sorting order query parameter to the request
+// WithSortingOrder adds a sorting order query parameter to the request
 func WithSortingOrder(order string) RequestOp {
 	return func(req *http.Request) error {
 		values, err := url.ParseQuery(req.URL.RawQuery)
@@ -326,17 +326,13 @@ func (c *Client) doRequest(req *http.Request, reqOps ...RequestOp) ([]byte, erro
 				return nil, err
 			}
 		}
-		return nil, fmt.Errorf("bad status code %q", resp.Status)
+		return nil, fmt.Errorf("bad status code %q: %s", resp.Status, buf)
 	}
 	buf, err := ioutil.ReadAll(resp.Body)
 	log.Tracef("HTTP response body: %s", buf)
 	if err != nil {
 		return nil, err
 	}
-	if resp.StatusCode < 200 || resp.StatusCode >= 300 {
-		return nil, fmt.Errorf("bad status code %q: %s", resp.Status, string(buf))
-	}
-
 	return buf, nil
 }