Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment E2E and linter steps in release pipeline, as we already did a… #222

Merged
merged 1 commit into from
Feb 27, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/release-weekly-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ jobs:
- name: Check license headers
run: make validate

- name: Run golangci-lint
run: make lint
# - name: Run golangci-lint
# run: make lint

build:
name: Cross compile
Expand Down Expand Up @@ -97,11 +97,11 @@ jobs:
- name: Extract platform binary
run: mv dist/hub-tool-packages/* dist/ && make -f builder.Makefile ci-extract

- name: Run e2e tests
env:
E2E_HUB_USERNAME: ${{ secrets.E2E_HUB_USERNAME }}
E2E_HUB_TOKEN: ${{ secrets.E2E_HUB_TOKEN }}
run: make TAG_NAME=${{ github.event.inputs.tag }} e2e
# - name: Run e2e tests
# env:
# E2E_HUB_USERNAME: ${{ secrets.E2E_HUB_USERNAME }}
# E2E_HUB_TOKEN: ${{ secrets.E2E_HUB_TOKEN }}
# run: make TAG_NAME=${{ github.event.inputs.tag }} e2e

release:
name: Do GitHub release
Expand Down
Loading