Skip to content
This repository has been archived by the owner on Jun 11, 2021. It is now read-only.

improve linux terminal link error message #2084

Merged
merged 1 commit into from Jan 3, 2017
Merged

improve linux terminal link error message #2084

merged 1 commit into from Jan 3, 2017

Conversation

bebehei
Copy link
Contributor

@bebehei bebehei commented Oct 31, 2016

After clicking on the exec-Button, a message popped up, stating The terminal emulator symbolic link doesn\'t exists. Please read the Wiki at https://github.com/docker/kitematic/wiki/Early-Linux-Support..

Sadly:

  1. the message gives no indication of the problem.
  2. The link given in the message, points to the wiki-site Early-Linux-Support, which is except a link is empty
  3. The Link contains an anchor #early-linux-support-from-zedtux, which does not exist on the linked Wiki-Site.

I got my indication out of #1648.

It may also be good to remove the bad links in the message (and) remove the bad wiki-pages.

@FrenchBen
Copy link
Contributor

Thanks for fixing this - Would you be able to provide an alternative terminal emulator that worked for you?

@bebehei
Copy link
Contributor Author

bebehei commented Nov 7, 2016

Using the symlink /usr/bin/x-terminal-emulator is the perfect thing. It gives programmers the ability to use any terminal-emulator without big hassle.

It's just not linked on every system. This PR only improves the error message, nothing more. The next user should know, what to fix.

@FrenchBen
Copy link
Contributor

It seems that the wiki should then be updated, as the page you mention: https://github.com/docker/kitematic/wiki/Early-Linux-Support points to another wiki page, which has none of the Linux information.

Do you mind updating that page also noting what distro needs the symlink created?

@bebehei
Copy link
Contributor Author

bebehei commented Dec 26, 2016

@FrenchBen I changed the corresponding wiki page. Could you please merge it?

@FrenchBen FrenchBen merged commit 6ebb035 into docker:master Jan 3, 2017
@FrenchBen
Copy link
Contributor

Thanks for the patch!

khadorkin added a commit to khadorkin/kitematic that referenced this pull request Jan 6, 2017
improve linux terminal link error message (docker#2084)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants