Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock() of Locker interface should probably take a receive-only channel #175

Open
debedb opened this issue Aug 3, 2017 · 0 comments
Open

Comments

@debedb
Copy link

debedb commented Aug 3, 2017

Lock() of Locker interface should probably take a receive-only channel for stopChan, that is, instead of

Lock(stopChan chan struct{}) (<-chan struct{}, error)

have

Lock(<-stopChan chan struct{}) (<-chan struct{}, error)

Lock would not be writing to stopChan, the user of the Lock will - and this signature will allow using things like Context's Done channel directly (without mediating it with another select).

debedb added a commit to debedb/libkv that referenced this issue Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant