Redis/RedisCluster store

[runcom]

I'm working on implementing Redis/RedisCluster here in libkv, I just need to understand if this would be something you like/need so I can go ahead.
Also to discuss whether to support directly RedisCluster via https://godoc.org/gopkg.in/redis.v3#ClusterClient or just the single instance client (I'd go with the cluster)
(even if redis support many data types I think the simple key/value would be ok here)

[abronan]

This can be definitely useful :)

The only issue I see so far with Redis is that it does not support Compare and Swap operations, so it would only implement a subset of the interface. Although we can probably mimic a CAS like operator with some other call of the cluster client.

I'm not against it if the lack of operation (if any) is properly handled in the lib.

@aluzzardi Thoughts?

[aluzzardi]

I can see it being useful - although before jumping in I'd like to see at least a few people interested on it.

@runcom How about opening an issue on docker/swarm asking who'd be interested in a redis backend for discovery, leader election and storage?

My main concern is that, compared to the others, redis is not strongly persistent. We are going to use libkv to store persistant data: if redis gets restarted we'll lose data.

[abronan]

+1 👍

[mavenugo]

@aluzzardi @runcom @abronan actually we were also thinking of implementing an eventually consistent data-store backend (redis was my first choice). we can discuss further on this if interested.

[runcom]

@aluzzardi redis has an option to store on disk and many redis deployment use it (elasticache on aws for instance) so chances to restart and lose data are small (there aren't)
I'll open an issue in swarm and link here tho

[rbishop]

I would like to see this as well!

[vcastellm]

👍 I'll use it, but not for swarm but for other project

[abronan]

@runcom Still interested in the Redis store implementation? 😃 I saw a few people interested so far.

[runcom]

@abronan sure, if there's no rush on this I'll work on it this weekend

[abronan]

Absolutely no rush, take the time needed and we'll review it when it's done if you are still interested in doing it. It is a nice added backend for libkv users though :)

[hsinhoyeh]

hi,
I think this feature is quiet useful in many applications, do we have any progress update here?
If not, we can have a design doc first, then others, like me, can do the help.

[allencloud]

@rbishop Great！
＋1

[abronan]

Hi @hsinhoyeh, no update so far, feel free to open a new issue with a proposal and you feel like tackling this integration :)

What's cool is that we have a test suite that could help validate the behavior of the store but redis wouldn't have to support all the calls I guess or maybe it can but we can discuss this during the design phase (for Locks and CAS and/or watches).

[hsinhoyeh]

@abronan I have created a short design doc in issue #116 , feel free to add comments. thanks

[abronan]

Closing in favor of #116