Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MySQL backend implementant and support all methods #180

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

lrita
Copy link

@lrita lrita commented Aug 25, 2017

All feature has been tested at local.
Signed-off-by: lrita lrita@163.com

  Signed-off-by: lrita <lrita@163.com>
We will get nil from the watching channel if the key isn't exist
or has been deleted.

Signed-off-by: lrita <lrita@163.com>
@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "backend-mysql" git@github.com:lrita/libkv.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353933104
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants