Fix etcd Lock bugs #186
Merged
Fix etcd Lock bugs #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 18, 2017 12:53
1. Any connection errors on the first key Set attempt may cause 2 clients to think they have acquired the lock if the second set attempt succeeds. 2. The wait loop was not checking for 'compareAndDelete' events which means that a client may never retry to set the lock key. Docker-DCO-1.1-Signed-off-by: Josh Hawn <josh.hawn@docker.com> (github: jlhawn)
First, run each test case as separate sub-tests. Added a test case for Consul and etcd which asserts that clients correctly block if the lock key is already held by another client. It also tests that the waiting client unblocks once the lock is released. Docker-DCO-1.1-Signed-off-by: Josh Hawn <josh.hawn@docker.com> (github: jlhawn)
jlhawn
force-pushed
the
fix_etcd_lock
branch
from
b594946
to
8699b1f
Compare
|
LGTM |
This was referenced Dec 19, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cause 2 clients to think they have acquired the lock if
the second set attempt succeeds.
events which means that a client may never retry to set
the lock key.