Add TTL to Consul lock using store.LockOptions #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm travis can't bootstrap Consul, download URL might have changed or something... (All good now) |
abronan
force-pushed
the
consul_ttl_lock
branch
3 times, most recently
from
fc90a37
to
91ec10e
Compare
abronan
force-pushed
the
consul_ttl_lock
branch
2 times, most recently
from
5531f77
to
2f34123
Compare
…Lock ttl behavior Signed-off-by: Alexandre Beslic <abronan@docker.com>
abronan
force-pushed
the
consul_ttl_lock
branch
from
2f34123
to
9a4eca4
Compare
|
LGTM |
vieux
added a commit
that referenced
this pull request
Sep 23, 2015
Add TTL to Consul lock using store.LockOptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to docker-archive/classicswarm#930 and docker-archive/classicswarm#1227
Add TTL on
Lockfor Consul and add tests foretcd,consulandzookeeper.Also includes a
stopChanfor Consul and etcd in order to perform the test on the LockTTL.Signed-off-by: Alexandre Beslic abronan@docker.com