Fix a lb rule race in loadbalancer #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a goroutine which is adding the service and another which is adding just a destination interleave the destination which is dependent on the service may not get added and will result in service working at reduced scale. The fix is to synchronize this with the service mutex. Signed-off-by: Jana Radhakrishnan <mrjana@docker.com>
|
LGTM |
|
Looking through all these PRs about service & LB & Agent. I feel a little hard to understand whats going on. Is there some global design docs that could be shared before getting started like #767 when we start to introduce DNS support? Thanks. |
|
@chenchun Please take a look at moby/moby#23361 and moby/moby#23362 for more background. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a goroutine which is adding the service and another which is adding
just a destination interleave the destination which is dependent on the
service may not get added and will result in service working at reduced
scale. The fix is to synchronize this with the service mutex.
Signed-off-by: Jana Radhakrishnan mrjana@docker.com