control-plane hardening: cleanup local state on peer leaving a network #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Santhosh Manohar <santhosh@docker.com>
sanimej
changed the title
aboch
reviewed
Mar 31, 2017
| @@ -372,6 +372,37 @@ func (nDB *NetworkDB) deleteNetworkEntriesForNode(deletedNode string) { | |||
| nDB.Unlock() | |||
| } | |||
|
|
|||
| func (nDB *NetworkDB) deleteNodeNetworkEntries(nid, node string) { | |||
| nDB.Lock() | |||
There was a problem hiding this comment.
Is it necessary or can we avoid to to lock the nDB around the walk ?
There was a problem hiding this comment.
@aboch We have to take the lock in this case since the network DB entries have to updated.
|
LGTM |
1 similar comment
|
LGTM |
sanimej
pushed a commit
that referenced
this pull request
Jun 25, 2017
backport libnetwork #1704 to 1.13/17.03 branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the last task on an overlay network is shutdown, the node will leave from the network. Once a node leaves the network subsequence bulksync updates won't include the state for that network. If a bunch of tasks on a network are shutdown when there other network issues some of the gossip updates might be lost. If the network leave event does reach the peers they should cleanup the local state. Not doing so will leave the missed gossip state updates permanently in the peers' networkdb.
Signed-off-by: Santhosh Manohar santhosh@docker.com