Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle proxy settings for aws-sdk #152

Merged
merged 1 commit into from Feb 17, 2022
Merged

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Feb 16, 2022

fixes #146

cc @Flydiverny @svasek

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Copy link
Contributor

@Flydiverny Flydiverny left a comment

Looks reasonable to me! :)

@svasek
Copy link

@svasek svasek commented Feb 17, 2022

Hi @crazy-max,
🎉 Congratulation! I can confirm it works like a charm in both scenarios.
So, It works even with the aws-actions/configure-aws-credentials.

It's also not necessary to set additional env for the step if proxy is set in the runner global environment.
Thank you very much. Good job!

► Run crazy-max/docker-login-action@aws-sdk-proxy
::save-state name=isPost::true
##[debug]Save intra-action state isPost = true
::save-state name=registry::***.dkr.ecr.us-west-2.amazonaws.com
##[debug]Save intra-action state registry = ***.dkr.ecr.us-west-2.amazonaws.com
::save-state name=logout::true
##[debug]Save intra-action state logout = true
Retrieving registries data through AWS SDK...
##[debug]Requesting AWS ECR auth token for ***
##[debug]Using http proxy http://proxy-us-aws.***.***:3128
##[debug]Using https proxy http://proxy-us-aws.***.***:3128
AWS ECR detected with us-west-2 region
(node:910) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Logging into https://***.dkr.ecr.us-west-2.amazonaws.com...
Login Succeeded!
##[debug]Node Action run completed with exit code 0
##[debug]Finishing: Login to AWS ECR

@crazy-max crazy-max merged commit 6af3c11 into docker:master Feb 17, 2022
2 checks passed
@crazy-max crazy-max deleted the aws-sdk-proxy branch Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants