Investigate 1954 certificate always regenerated

Signed-off-by: David Gageot <david@gageot.net>

commands/commands.go

@@ -419,6 +419,7 @@ func runActionForeachMachine(actionName string, machines []*host.Host) []error {
 		go machineCommand(actionName, machine, serialChan)
 		if err := <-serialChan; err != nil {
 			log.Errorln(err)
+			errs = append(errs, err)
 		}
 		close(serialChan)
 	}

commands/config.go

@@ -82,7 +82,7 @@ func checkCert(hostUrl string, authOptions *auth.AuthOptions, c *cli.Context) er
 		authOptions.ServerKeyPath,
 	)
 	if err != nil {
-		return fmt.Errorf("Error attempting to validate the certficate: %s", err)
+		return fmt.Errorf("Error attempting to validate the certs: %s", err)
 	}
 
 	if !valid {

libmachine/cert/cert.go

@@ -13,6 +13,8 @@ import (
 	"net"
 	"os"
 	"time"
+
+	"github.com/docker/machine/libmachine/log"
 )
 
 type ErrValidatingCert struct {
@@ -174,6 +176,7 @@ func GenerateCert(hosts []string, certFile, keyFile, caFile, caKeyFile, org stri
 	return nil
 }
 
+// ValidateCertificate validate the certificate installed on the vm.
 func ValidateCertificate(addr, caCertPath, serverCertPath, serverKeyPath string) (bool, error) {
 	caCert, err := ioutil.ReadFile(caCertPath)
 	if err != nil {
@@ -195,12 +198,15 @@ func ValidateCertificate(addr, caCertPath, serverCertPath, serverKeyPath string)
 		return false, ErrValidatingCert{err}
 	}
 
+	log.Debugf("Configuration: +%v", tlsConfig)
+
 	dialer := &net.Dialer{
 		Timeout: time.Second * 2,
 	}
 
 	_, err = tls.DialWithDialer(dialer, "tcp", addr, tlsConfig)
 	if err != nil {
+		log.Debugf("Certs are not valid: %s", err)
 		return false, nil
 	}
 

libmachine/provision/utils.go

@@ -179,11 +179,7 @@ func ConfigureAuth(p Provisioner) error {
 		return err
 	}
 
-	if err := waitForDocker(p, dockerPort); err != nil {
-		return err
-	}
-
-	return nil
+	return waitForDocker(p, dockerPort)
 }
 
 func matchNetstatOut(reDaemonListening, netstatOut string) bool {