Skip to content
This repository has been archived by the owner on Sep 26, 2021. It is now read-only.

Missing KillMode=process in docker.service cause live-restore fail. #3963

Closed
twang2218 opened this issue Jan 24, 2017 · 0 comments
Closed

Missing KillMode=process in docker.service cause live-restore fail. #3963

twang2218 opened this issue Jan 24, 2017 · 0 comments
Labels

Comments

@twang2218
Copy link
Contributor

As discussed in moby/moby#30308, I created a Digital Ocean droplet, with Ubuntu 16.04 on it, and the live-restore is failed to use.

It becasue the /etc/systemd/system/multi-user.target.wants/docker.service didn't contain the same settings in the https://github.com/docker/docker/blob/master/contrib/init/systemd/docker.service , especially, in this case, the KillMode=process is missing, which is the reason live-restore doesn't work in the docker host created by docker-machine.

Should we consider using systemd drop-in settings instead? So most other settings can be inherited from the default package settings.

twang2218 added a commit to twang2218/machine that referenced this issue Jan 25, 2017
Using systemd drop-in for the configuration is better for inherit the
package default settings, without the need of sync the settings
between 2 projects.

Fixes docker#3963

Signed-off-by: Tao Wang <twang2218@gmail.com>
afbjorklund pushed a commit to minikube-machine/machine that referenced this issue Jun 10, 2023
Using systemd drop-in for the configuration is better for inherit the
package default settings, without the need of sync the settings
between 2 projects.

Fixes docker/machine#3963

Signed-off-by: Tao Wang <twang2218@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants