Remove azure driver temporarily + Godeps for new azure driver #3157
Conversation
Please sign your commits following these rules: $ git clone -b "azure" git@github.com:ahmetalpbalkan/machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f Ammending updates the existing PR. You DO NOT need to open a new one. |
This commit temporarily removes Azure driver and its dependencies from the source tree and adds dependencies for the new Azure driver (so that Azure driver PR will not have godeps changes and will be easier to review). Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
LGTM |
Remove azure driver temporarily + Godeps for new azure driver
thanks aaand here's the actual PR #3159 |
OK @dgageot @jeanlaurent I went ahead and merged this but it occurs to me that there there are probably at least a few instances of existing |
Maybe Azure just works way better than the other clouds and that's why there are orders of magnitude fever errors. |
@nathanleclaire haha I wouldn't be surprised if those errors were me while trying to develop this. 😛 Azure is not super big on Linux just yet (we're about a 25% Linux cloud) but that's growing rapidly. I'm constantly getting emails from customers using docker-machine on Azure, it appears like there is a demand for it (that's why we did this after all). I think the new driver is solid from Azure perspective, there might be still some flakiness that we can address over time but yesterday I created about 250 machines and all failures were due to non-Azure issues. |
@ahmetalpbalkan Yup, no doubt that it could be a very popular driver -- my concern is largely just that we shouldn't leave existing users of the |
@nathanleclaire Yes, a large note about the breaking change will be really useful. We can suggest sticking to older versions of machine for existing VMs or re-importing the VM to the |
@ahmetalpbalkan If possible, we should add a "safety gate" to refuse to move forward with any Machine operations given the new |
This commit temporarily removes Azure driver and its dependencies from the source tree and adds dependencies for the new Azure driver (so that Azure driver PR will not have godeps changes and will be
easier to review).
Very shortly after this is merged I will send the actual PR for the new azure driver.