Skip to content
This repository has been archived by the owner on Sep 26, 2021. It is now read-only.

Rename github.com/codegangsta/cli to github.com/urfave/cli #3992

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fate-grand-order
Copy link
Contributor

rename github.com/codegangsta/cli to github.com/urfave/cli

Notice: This is the library formerly known as github.com/codegangsta/cli -- Github will automatically redirect requests to this repository, but we recommend updating your references for clarity.

Signed-off-by: fate-grand-order chenjg@harmonycloud.cn

@nathanleclaire
Copy link
Contributor

Is that revision in Godep contained in the urfave respository?

@fate-grand-order
Copy link
Contributor Author

fate-grand-order commented Feb 20, 2017

yes, the NOTICE in https://github.com/urfave/cli says

Notice: This is the library formerly known as github.com/codegangsta/cli -- Github will automatically redirect requests to this repository, but we recommend updating your references for clarity.

@nathanleclaire

@nathanleclaire
Copy link
Contributor

This needs rebase due to some other Godep changes. Will you rebase it please?

Signed-off-by: fate-grand-order <chenjg@harmonycloud.cn>
@fate-grand-order
Copy link
Contributor Author

I have rebased it. Please review it again. @nathanleclaire

@dgageot
Copy link
Member

dgageot commented Nov 17, 2017

@fate-grand-order The build is failing because the code is not properly formatted now. We use go import to sort the imports. Now that you renamed an import, go import needs to be run again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants