Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull_request_target triggers the event=branch when it should only trigger on event=pr #96

Closed
mithro opened this issue May 25, 2021 · 0 comments · Fixed by #97
Closed
Labels

Comments

@mithro
Copy link

mithro commented May 25, 2021

@crazy-max -- I'm still getting a tag for the base branch (IE localhost:5000/run-drc-for-cell-gds-using-magic:main) - Have I configured things wrong or is pull_request_target getting misunderstood as being a branch/tag event as well as a pull request event? Output below;

  with:
    images: localhost:5000/run-drc-for-cell-gds-using-magic,gcr.io/skywater-pdk/actions/run-drc-for-cell-gds-using-magic
    tags: type=ref,event=tag
  type=ref,event=pr
  type=ref,event=branch
  type=sha
  type=sha,format=long
  
    github-token: ***
  env:
    ACTION_NAME: run-drc-for-cell-gds-using-magic
Context info
  eventName: pull_request_target
  sha: 1791415f66d16e92bdc523c59e68383db3b32d74
  ref: refs/heads/main
  workflow: Build Docker Image for Run DRC for cell GDS (using Magic) Action
  action: dockermetadata-action
  actor: mithro
  runNumber: 22
  runId: 875362048
Processing tags input
Processing flavor input
Docker image version
  pr-21
Docker tags
  localhost:5000/run-drc-for-cell-gds-using-magic:pr-21
  localhost:5000/run-drc-for-cell-gds-using-magic:main
  localhost:5000/run-drc-for-cell-gds-using-magic:sha-1791415
  localhost:5000/run-drc-for-cell-gds-using-magic:sha-1791415f66d16e92bdc523c59e68383db3b32d74
  gcr.io/skywater-pdk/actions/run-drc-for-cell-gds-using-magic:pr-21
  gcr.io/skywater-pdk/actions/run-drc-for-cell-gds-using-magic:main
  gcr.io/skywater-pdk/actions/run-drc-for-cell-gds-using-magic:sha-1791415
  gcr.io/skywater-pdk/actions/run-drc-for-cell-gds-using-magic:sha-1791415f66d16e92bdc523c59e68383db3b32d74

Originally posted by @mithro in #90 (comment)

mithro added a commit to mithro/skywater-pdk-actions that referenced this issue May 25, 2021
Add temporary workaround for issue described in
docker/metadata-action#96

Using fix suggested by @crazy-max in
docker/metadata-action#90 (comment)

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants