Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README (Issue #116) #119

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Update README (Issue #116) #119

merged 1 commit into from
Aug 3, 2021

Conversation

theo-brown
Copy link
Contributor

See Issue #116.

README modified to make it clear that this action extracts metadata from Git to tag Docker images, rather than getting metadata from the docker registry.

README.md Outdated Show resolved Hide resolved
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign-off is missing for DCO.

@theo-brown
Copy link
Contributor Author

Sign-off is missing for DCO.

Should be done now, also tidied up my merge mess a bit.

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes suggested in #119 (comment) not applied anymore. Please check again.

Signed-off-by: Theo Brown <7982453+theo-brown@users.noreply.github.com>
@theo-brown
Copy link
Contributor Author

Changes suggested in #119 (comment) not applied anymore. Please check again.

Really sorry, my mistake! Should be all fixed up now.

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazy-max crazy-max merged commit a67f45c into docker:master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants