-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README (Issue #116) #119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign-off is missing for DCO.
e9a815f
to
dba1df9
Compare
Should be done now, also tidied up my merge mess a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes suggested in #119 (comment) not applied anymore. Please check again.
Signed-off-by: Theo Brown <7982453+theo-brown@users.noreply.github.com>
Really sorry, my mistake! Should be all fixed up now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
See Issue #116.
README modified to make it clear that this action extracts metadata from Git to tag Docker images, rather than getting metadata from the docker registry.