Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tag-suffix and tag-prefix options #47

Closed
wants to merge 2 commits into from

Conversation

CharlieC3
Copy link

@CharlieC3 CharlieC3 commented Mar 9, 2021

Adds tag-prefix and tag-suffix options.

  • tag-prefix will prepend the given string to the beginning of all Docker tags
    • e.g. If tag-prefix given is prepend-, my/app:dev becomes my/app:prepend-dev
  • tag-suffix will append the given string to the end of all Docker tags
    • e.g. If tag-suffix given is -append, my/app:dev becomes my/app:dev-append
  • Both options can be used simultaneously
  • Added new tests
  • All tests passing
  • Followed contribution guidelines

Addresses #13

@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #47 (dcdcc82) into master (5f29dbc) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   75.42%   75.42%           
=======================================
  Files           3        3           
  Lines         118      118           
  Branches       24       24           
=======================================
  Hits           89       89           
  Misses          7        7           
  Partials       22       22           
Impacted Files Coverage Δ
src/context.ts 85.71% <ø> (ø)
src/meta.ts 76.54% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f29dbc...dcdcc82. Read the comment docs.

@crazy-max
Copy link
Member

@CharlieC3 Thanks for your contrib but like I said in #15 (comment), I will focus on proposal in #30. I keep this one open in the meantime. Keep you in touch.

@crazy-max crazy-max mentioned this pull request Mar 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants