Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inital parsing of maintainers files #35

Merged
merged 1 commit into from
Dec 4, 2015
Merged

inital parsing of maintainers files #35

merged 1 commit into from
Dec 4, 2015

Conversation

jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Dec 3, 2015

@jessfraz
Copy link
Contributor Author

jessfraz commented Dec 3, 2015

dont judge the code i wrote it fast 😇

@jessfraz jessfraz mentioned this pull request Dec 3, 2015
Merged
@jessfraz jessfraz mentioned this pull request Dec 3, 2015
Merged
@jessfraz
Copy link
Contributor Author

jessfraz commented Dec 3, 2015

part of moby/moby#18319

icecrime
icecrime reviewed Dec 3, 2015
View reviewed changes
MAINTAINERS
@@ -0,0 +1,169 @@
[Projects]
[Projects.docker]
Url = "https://github.com/docker/docker"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is BurntSushi/toml responsible for the weird indentation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@icecrime
Copy link

icecrime commented Dec 3, 2015

That's really really cool, thanks @jfrazelle :-)

A few remarks:

  • I think the first ~200 lines of the MAINTAINERS files at docker/docker root should appear in this one. These are common rules and roles (like BDFL and chief architect).
  • If we do so, than we should keep the lists being nested under [Org] (as in: [Org.Maintainers.Docker], [Org.Maintainers.Compose].

thaJeztah
thaJeztah reviewed Dec 3, 2015
View reviewed changes
.gitignore

# Thumbnails
._*

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps those Thumb.db files as well for windows users

@thaJeztah
Copy link
Member

Nice @jfrazelle!

obviously opinionated, but how do we handle the docs maintainers? They're in a separate list in the docker/docker maintainers file, but are maintainers 😇

I can create pull requests for the other repos to convert them to TOML tomorrow

@jessfraz
Copy link
Contributor Author

jessfraz commented Dec 3, 2015

oh this was my bad :) will update

@jessfraz
Copy link
Contributor Author

jessfraz commented Dec 3, 2015

updated!

@jessfraz
Copy link
Contributor Author

jessfraz commented Dec 3, 2015

ah i see whill update per #35 (comment)

@jessfraz
Copy link
Contributor Author

jessfraz commented Dec 3, 2015

so actually hmmmm thats hard because i cant get the comments re parsing, like should we just have that hardcoded?

@thaJeztah
Copy link
Member

So, for the TOML, each repo should have a [Org."Core Maintainers"] entry, and that will be used?

@jessfraz
Copy link
Contributor Author

jessfraz commented Dec 3, 2015

ya i made a pr here that is currently working notaryproject/notary#333

@thaJeztah
Copy link
Member

Perhaps re: parsing, we should put those in a "description" node, or something?

@thaJeztah
Copy link
Member

Ah cool, want me to do the other repos tomorrow, using the same format?

@jessfraz
Copy link
Contributor Author

jessfraz commented Dec 3, 2015

ya so the rules can just live here and i will reformat the other roles to not be comments in this pr

@thaJeztah
Copy link
Member

Cool, thanks Jess!

@jessfraz
Copy link
Contributor Author

jessfraz commented Dec 4, 2015

ok so updated

This was referenced Dec 4, 2015
Merged
Merged
Merged
Merged
Merged
Merged
@thaJeztah thaJeztah mentioned this pull request Dec 4, 2015
Merged
@thaJeztah thaJeztah mentioned this pull request Dec 4, 2015
Merged
@jessfraz
inital parsing of maintainers files
57e15b3 
Signed-off-by: Jessica Frazelle <acidburn@docker.com>
@jessfraz
Copy link
Contributor Author

jessfraz commented Dec 4, 2015

im going to merge this just so i can set up automation to cron job and update 😇

jessfraz pushed a commit that referenced this pull request Dec 4, 2015
Merge pull request #35 from docker/add-maintainers-file-parsing
592c2cf 
inital parsing of maintainers files
@jessfraz jessfraz merged commit 592c2cf into master Dec 4, 2015
@jessfraz jessfraz deleted the add-maintainers-file-parsing branch December 4, 2015 17:38
@jessfraz jessfraz mentioned this pull request Dec 4, 2015
Merged
This was referenced Dec 5, 2015
Merged
Merged
Merged
Closed
Closed
Closed
Merged
Closed
Merged
Merged
Merged
stevesloka pushed a commit to stevesloka/kubecraft that referenced this pull request May 24, 2016
@jessfraz @stevesloka
this updates the MAINTAINERS file to the new toml format,
7d6368d 
so that it can be parsed and collected in the docker/opensource
repository.

see docker/opensource#35 and moby/moby#18321

Signed-off-by: Jessica Frazelle <acidburn@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jessfraz @icecrime @thaJeztah