Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

dep: update snyk to 1.1012.0 #215

Merged
merged 1 commit into from
Sep 27, 2022
Merged

dep: update snyk to 1.1012.0 #215

merged 1 commit into from
Sep 27, 2022

Conversation

eunomie
Copy link
Member

@eunomie eunomie commented Sep 27, 2022

- What I did

Update snyk to 1.1012.0

- How I did it

- How to verify it

- Description for the changelog

Update snyk version to be used to 1.1012.0.

- A picture of a cute animal (not mandatory)

@eunomie eunomie force-pushed the cpub-369-update-snyk branch 3 times, most recently from 383c1f0 to 83e3769 Compare September 27, 2022 08:50
Signed-off-by: Yves Brissaud <yves.brissaud@docker.com>
@eunomie eunomie requested a review from a team September 27, 2022 09:37
Copy link

@mcapell mcapell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -123,5 +123,8 @@ Provider: %s
}

func getProviderVersion(env string) string {
return fmt.Sprintf("Snyk (%s (standalone))", os.Getenv(env))
if runtime.GOOS != "windows" {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Why is this needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure what changed (but I validated it on a windows machine) but on windows machine, the standalone version doesn't print anymore (standalone) in the version, only on windows.
It's not a big issue, what we want to know here is we got the right version number.

@eunomie eunomie merged commit 5844996 into main Sep 27, 2022
@eunomie eunomie deleted the cpub-369-update-snyk branch September 27, 2022 10:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants