WIP - DO NOT MERGE - always download precompiled binaries first #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before this change, we would try to determine ahead of time if we should build from source. after this change, we try to download precompiled binaries first, and only fall back to a source build if that fails. building from source can take up to 2 minutes, so is probably too slow for most users. Signed-off-by: Nick Santos <nick.santos@docker.com>
nicks
changed the title
|
FYI -- the compiled js in this PR contains code vendored from docker/actions-toolkit#127, so we need to downstream that pr before merging this one. |
|
closing this one for now since docker/actions-toolkit#127 has been closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before this change, we would try to determine ahead of time if we should build from source.
after this change, we try to download precompiled binaries first, and only fall back to a source build if that fails.
building from source can take up to 2 minutes, so is probably too slow for most users.