-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance builder inspection #69
Conversation
This comment has been minimized.
This comment has been minimized.
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
- Coverage 78.18% 76.51% -1.67%
==========================================
Files 5 5
Lines 110 132 +22
Branches 19 20 +1
==========================================
+ Hits 86 101 +15
- Misses 18 23 +5
- Partials 6 8 +2
Continue to review full report at Codecov.
|
if (line.startsWith('Platforms')) { | ||
return line.replace('Platforms: ', '').replace(/\s/g, '').trim(); | ||
const builder = {}; | ||
itlines: for (const line of res.stdout.trim().split(`\n`)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
follow up: should add json output (--format
) for these in build later to avoid this text parsing. Has been asked in buildx repo before as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes indeed would be better to support that directly on buildx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactor builder inspection and add new outputs. In a follow-up PR we will be able to display buildkitd logs (
docker logs buildx_buildkit_${builder.node_name}
) if docker-container is used to enhance debugging.Signed-off-by: CrazyMax crazy-max@users.noreply.github.com