dispatcher: Use Debug instead of Debugf #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2282 +/- ##
==========================================
+ Coverage 60.4% 60.48% +0.08%
==========================================
Files 125 125
Lines 20394 20394
==========================================
+ Hits 12318 12335 +17
+ Misses 6682 6667 -15
+ Partials 1394 1392 -2 |
ijc
reviewed
Jun 22, 2017
manager/dispatcher/dispatcher.go
Outdated
| @@ -1118,7 +1118,7 @@ func (d *Dispatcher) Session(r *api.SessionRequest, stream api.Dispatcher_Sessio | |||
| // get the node IP addr | |||
| addr, err := nodeIPFromContext(stream.Context()) | |||
| if err != nil { | |||
| log.G(ctx).Debugf(err.Error()) | |||
| log.G(ctx).Debug(err.Error()) | |||
There was a problem hiding this comment.
Is it better to use WithError(err).Debug("")?
There was a problem hiding this comment.
Updated this one to log a descriptive message instead of just spitting out the error.
aaronlehmann
force-pushed
the
debugf-error
branch
from
61963c3
to
d170570
Compare
When the argument is a string returned by Error, we don't want to use Debugf, since if the error string happens to include % characters, this will cause a format string error. Also prefer Debug over Debugf in cases where literal strings do not include any formatting (this part is purely cosmetic). Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
aaronlehmann
force-pushed
the
debugf-error
branch
from
d170570
to
8db89e3
Compare
|
LGTM |
1 similar comment
|
LGTM |
andrewhsu
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Jul 14, 2017
- moby/swarmkit#2266 (support for templating Node.Hostname in docker executor) - moby/swarmkit#2281 (change restore action on objects to be update, not delete/create) - moby/swarmkit#2285 (extend watch queue with timeout and size limit) - moby/swarmkit#2253 (version-aware failure tracking in the scheduler) - moby/swarmkit#2275 (update containerd and port executor to container client library) - moby/swarmkit#2292 (rename some generic resources) - moby/swarmkit#2300 (limit the size of the external CA response) - moby/swarmkit#2301 (delete global tasks when the node running them is deleted) Minor cleanups, dependency bumps, and vendoring: - moby/swarmkit#2271 - moby/swarmkit#2279 - moby/swarmkit#2283 - moby/swarmkit#2282 - moby/swarmkit#2274 - moby/swarmkit#2296 (dependency bump of etcd, go-winio) Signed-off-by: Ying Li <ying.li@docker.com> Upstream-commit: 4509a00 Component: engine
silvin-lubecki
pushed a commit
to silvin-lubecki/engine-extract
that referenced
this pull request
Mar 16, 2020
- moby/swarmkit#2266 (support for templating Node.Hostname in docker executor) - moby/swarmkit#2281 (change restore action on objects to be update, not delete/create) - moby/swarmkit#2285 (extend watch queue with timeout and size limit) - moby/swarmkit#2253 (version-aware failure tracking in the scheduler) - moby/swarmkit#2275 (update containerd and port executor to container client library) - moby/swarmkit#2292 (rename some generic resources) - moby/swarmkit#2300 (limit the size of the external CA response) - moby/swarmkit#2301 (delete global tasks when the node running them is deleted) Minor cleanups, dependency bumps, and vendoring: - moby/swarmkit#2271 - moby/swarmkit#2279 - moby/swarmkit#2283 - moby/swarmkit#2282 - moby/swarmkit#2274 - moby/swarmkit#2296 (dependency bump of etcd, go-winio) Signed-off-by: Ying Li <ying.li@docker.com> Upstream-commit: 4509a00 Component: engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the argument is a string returned by
Error, we don't want to useDebugf, since if the error string happens to include % characters, this will cause a format string error.Also prefer
DebugoverDebugfin cases where literal strings do not include any formatting (this part is purely cosmetic).