Update x/crypto for salsa fix #2838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes golang/go#30965 This should not break any update, as we should not be encrypting more than 256GB data, as we only use secretbox for encrypting Raft values. Signed-off-by: Justin Cormack <justin.cormack@docker.com>
justincormack
added a commit
to justincormack/docker
that referenced
this pull request
Mar 21, 2019
Fixes issues with salsa which is used in swarmkit, see moby/swarmkit#2838 As we only encrypt small values this should be a non breaking change. Signed-off-by: Justin Cormack <justin.cormack@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #2838 +/- ##
==========================================
- Coverage 62.19% 62.15% -0.05%
==========================================
Files 139 139
Lines 22314 22314
==========================================
- Hits 13879 13869 -10
+ Misses 6962 6957 -5
- Partials 1473 1488 +15 |
tonistiigi
approved these changes
Mar 21, 2019
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Mar 22, 2019
Fixes issues with salsa which is used in swarmkit, see moby/swarmkit#2838 As we only encrypt small values this should be a non breaking change. Signed-off-by: Justin Cormack <justin.cormack@docker.com> Upstream-commit: b3251001c6757c744ae7a3eaf07633abd0967cfe Component: engine
adhulipa
pushed a commit
to adhulipa/docker
that referenced
this pull request
Apr 11, 2019
Fixes issues with salsa which is used in swarmkit, see moby/swarmkit#2838 As we only encrypt small values this should be a non breaking change. Signed-off-by: Justin Cormack <justin.cormack@docker.com>
kiku-jw
pushed a commit
to kiku-jw/moby
that referenced
this pull request
May 16, 2019
Fixes issues with salsa which is used in swarmkit, see moby/swarmkit#2838 As we only encrypt small values this should be a non breaking change. Signed-off-by: Justin Cormack <justin.cormack@docker.com>
thaJeztah
pushed a commit
to thaJeztah/docker
that referenced
this pull request
Aug 27, 2019
Fixes issues with salsa which is used in swarmkit, see moby/swarmkit#2838 As we only encrypt small values this should be a non breaking change. Signed-off-by: Justin Cormack <justin.cormack@docker.com> (cherry picked from commit b325100) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes fix for golang/go#30965
This should not break any update, as we should not be encrypting more than
256GB data, as we only use secretbox for encrypting Raft values.
Signed-off-by: Justin Cormack justin.cormack@docker.com
- What I did
- How I did it
- How to test it
- Description for the changelog