Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run jobs in //, do not run Trivy anymore as we have atomist that provides better feedback #74

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

gtardif
Copy link
Contributor

@gtardif gtardif commented Sep 15, 2022

(no need to build local image first)

Signed-off-by: Guillaume Tardif guillaume.tardif@gmail.com

@github-actions
Copy link

github-actions bot commented Sep 15, 2022

Docker image tag(s) pushed:

docker/volumes-backup-extension:pr-74

Labels added to images:

org.opencontainers.image.title=volumes-backup-extension
org.opencontainers.image.description=Back up, clone, restore, and share Docker volumes effortlessly.
org.opencontainers.image.url=https://github.com/docker/volumes-backup-extension
org.opencontainers.image.source=https://github.com/docker/volumes-backup-extension
org.opencontainers.image.version=pr-74
org.opencontainers.image.created=2022-09-15T14:02:21.309Z
org.opencontainers.image.revision=35ec262e6ac8c3d9388323ac6670f320aab18bdc
org.opencontainers.image.licenses=Apache-2.0
org.opencontainers.image.title=Volumes Backup & Share
org.opencontainers.image.description=Back up, clone, restore, and share Docker volumes effortlessly.
org.opencontainers.image.vendor=Docker Inc.
org.opencontainers.image.revision=a0fd6b787548886c47d70c4d1b5b1574909b723a

@atomist
Copy link
Contributor

atomist bot commented Sep 15, 2022

Dockerfile

Vulnerabilities
Comparison

👏 No new critical or high vulnerabilities compared with target branch main


Dockerfile

Vulnerabilities
Comparison

👏 No new critical or high vulnerabilities compared with target branch main


More details are available in the vulnerability report

@@ -37,7 +37,6 @@ jobs:
run: go test -v ./... --count=1

build-image:
needs: build-tests
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gtardif The reason for having the needs is to avoid building and pushing the image in case the Go tests fail.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll keep it then

…ides better feedback (no need to build local image first)

Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
@felipecruz91 felipecruz91 merged commit a200a68 into main Sep 15, 2022
@felipecruz91 felipecruz91 deleted the clean_ci branch September 15, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants