Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): add ux improvements #80

Merged
merged 10 commits into from
Sep 20, 2022
Merged

feat(): add ux improvements #80

merged 10 commits into from
Sep 20, 2022

Conversation

lucbpz
Copy link
Contributor

@lucbpz lucbpz commented Sep 19, 2022

Address all UX improvements from our design team.

@atomist
Copy link
Contributor

atomist bot commented Sep 19, 2022

Dockerfile

docker/volumes-backup-extension:pr-80

Vulnerabilities
Comparison

👏 No new critical or high vulnerabilities compared with target branch main


Dockerfile

docker/volumes-backup-extension:pr-80

Vulnerabilities
Comparison

👏 No new critical or high vulnerabilities compared with target branch main


More details are available in the vulnerability report

@github-actions
Copy link

github-actions bot commented Sep 19, 2022

Docker image tag(s) pushed:

docker/volumes-backup-extension:pr-80

Labels added to images:

org.opencontainers.image.title=volumes-backup-extension
org.opencontainers.image.description=Back up, clone, restore, and share Docker volumes effortlessly.
org.opencontainers.image.url=https://github.com/docker/volumes-backup-extension
org.opencontainers.image.source=https://github.com/docker/volumes-backup-extension
org.opencontainers.image.version=pr-80
org.opencontainers.image.created=2022-09-20T14:44:07.328Z
org.opencontainers.image.revision=35c7572499e7be1283bd36c15d05689aa84c603d
org.opencontainers.image.licenses=Apache-2.0

Copy link
Collaborator

@felipecruz91 felipecruz91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After emptying the volume, the size needs to be recalculated (or set it to 0 directly if the empty action was successful).

ui/src/App.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@gtardif gtardif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM appart from @felipecruz91 comment on empty volume action (well spotted! )

@felipecruz91
Copy link
Collaborator

Added the following request to this PR too:

Copy link
Contributor

@gtardif gtardif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix MUI license watermark. This can be tested by installing the extension build for this PR in the CI, it should normally have the secret license key

@felipecruz91
Copy link
Collaborator

@gtardif LGTM

image

@felipecruz91 felipecruz91 merged commit 766998e into main Sep 20, 2022
@felipecruz91 felipecruz91 deleted the feature/ux-improvements branch September 20, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants