-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(): add ux improvements #80
Conversation
|
Vulnerabilities |
Comparison |
👏 No new critical or high vulnerabilities compared with target branch main
Dockerfile
docker/volumes-backup-extension:pr-80
Vulnerabilities |
Comparison |
👏 No new critical or high vulnerabilities compared with target branch main
More details are available in the vulnerability report
Docker image tag(s) pushed:
Labels added to images:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After emptying the volume, the size needs to be recalculated (or set it to 0 directly if the empty action was successful).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM appart from @felipecruz91 comment on empty volume action (well spotted! )
Added the following request to this PR too: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix MUI license watermark. This can be tested by installing the extension build for this PR in the CI, it should normally have the secret license key
@gtardif LGTM |
Address all UX improvements from our design team.