Support backwards compatibility when importing .tar.gz archives from previous version #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docker image tag(s) pushed: Labels added to images: |
gtardif
reviewed
Sep 21, 2022
| @@ -76,6 +76,13 @@ func (h *Handler) ImportTarGzFile(ctx echo.Context) error { | |||
| return err | |||
| } | |||
|
|
|||
| //fileName := filepath.Base(path) | |||
| rmCmd := "rm -rf /vackup-volume/..?* /vackup-volume/.[!.]* /vackup-volume/*" | |||
There was a problem hiding this comment.
This command looks a bit over-complicated, why do we need this syntax ?
There was a problem hiding this comment.
This is necessary to remove hidden and not-hidden files and folders. I've added a comment with an explanation.
felipecruz91
force-pushed
the
feature/import-backwards-compatibility
branch
from
8d0aeb6
to
9b3d1c5
Compare
felipecruz91
force-pushed
the
feature/import-backwards-compatibility
branch
from
9b3d1c5
to
bac89f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.