Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed volume mounts from compose files #149

Closed
wants to merge 55 commits into from
Closed

Removed volume mounts from compose files #149

wants to merge 55 commits into from

Conversation

larryclaman
Copy link

removed volume mounts per issue #148

removed volume mount
removed volume mount
@karunpabbi
Copy link

Need to have authentication part

@JimCodified
Copy link

I think we'll want to have one Compose file that does still have the volume mounts, specifically to show the dev use case. What I'd propose is copying the current docker-compose-simple.yml to docker-compose-dev.yml and then we can take the mounts out of the other files.

@BretFisher
Copy link
Member

Sorry no one responded a year ago. This is a big commit set, and I'm not sure what the focus is anymore of this 55-commit PR. I'm going to close this, but if you'd like to submit a small PR, please open a ticket for a problem you'd like to solve first, and that way we can ensure the PR focuses on a single fix, thanks!

@BretFisher BretFisher closed this Dec 14, 2020
@larryclaman
Copy link
Author

My bad... I had completely forgotten about this PR, and recently I started using my fork as the basis for some experimentation. My apologies that these recent edits got pushed back into the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants