Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring + rename crate coconut to coconut-crypto #11

Merged
merged 19 commits into from
Mar 29, 2023
Merged

Refactoring + rename crate coconut to coconut-crypto #11

merged 19 commits into from
Mar 29, 2023

Conversation

olegnn
Copy link
Contributor

@olegnn olegnn commented Mar 24, 2023 •
edited
Loading

  • Rename crate coconut to coconut-crypto
  • Share utils from the coconut crate
  • Refactor PoKOfSignatureG1Protocol::init of the BBSPlus

@olegnn olegnn requested a review from lovesh March 24, 2023 17:15
lovesh
lovesh requested changes Mar 24, 2023
View reviewed changes
bbs_plus/src/setup.rs Outdated Show resolved Hide resolved
proof_system/src/sub_protocols/bbs_plus.rs Outdated Show resolved Hide resolved
proof_system/src/sub_protocols/bbs_plus.rs Outdated Show resolved Hide resolved
@olegnn olegnn force-pushed the share-utils-refactor-bbs-plus-init branch from f2e01f0 to 12ff67e Compare March 27, 2023 14:04
@olegnn olegnn force-pushed the share-utils-refactor-bbs-plus-init branch from b459184 to 553fb4e Compare March 27, 2023 18:15
@olegnn olegnn changed the base branch from main to aggr March 27, 2023 18:19
@olegnn olegnn changed the base branch from aggr to main March 27, 2023 18:19
@olegnn olegnn force-pushed the share-utils-refactor-bbs-plus-init branch from 553fb4e to 39a66cd Compare March 27, 2023 18:29
@olegnn olegnn force-pushed the share-utils-refactor-bbs-plus-init branch from 39a66cd to daa17e4 Compare March 27, 2023 18:37
@olegnn olegnn force-pushed the share-utils-refactor-bbs-plus-init branch from 11e7b9a to 0e86b56 Compare March 27, 2023 18:46
@olegnn olegnn force-pushed the share-utils-refactor-bbs-plus-init branch 2 times, most recently from ad5d8b9 to 53b8434 Compare March 28, 2023 10:38
@olegnn olegnn force-pushed the share-utils-refactor-bbs-plus-init branch from 53b8434 to b79cd5d Compare March 28, 2023 10:47
lovesh
lovesh reviewed Mar 28, 2023
View reviewed changes
.github/workflows/test.yml Show resolved Hide resolved
Cargo.lock
@@ -0,0 +1,2829 @@
# This file is automatically @generated by Cargo.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is lock file included? Which dependencies are requiring the need to be included?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, but you could check the build history, for ex. https://github.com/docknetwork/crypto/actions/runs/4535405844/jobs/7990814323
Without the lockfile build was failing.

proof_system/src/sub_protocols/ps_signature.rs Outdated Show resolved Hide resolved
@olegnn olegnn force-pushed the share-utils-refactor-bbs-plus-init branch from 6f0b734 to 2cd81bd Compare March 28, 2023 17:33
@olegnn olegnn force-pushed the share-utils-refactor-bbs-plus-init branch from 2cd81bd to ad86820 Compare March 28, 2023 18:01
lovesh
lovesh requested changes Mar 28, 2023
View reviewed changes
saver/src/error.rs Outdated Show resolved Hide resolved
saver/src/encryption.rs Outdated Show resolved Hide resolved
saver/src/encryption.rs Outdated Show resolved Hide resolved
@lovesh lovesh merged commit e03df83 into main Mar 29, 2023
@lovesh lovesh deleted the share-utils-refactor-bbs-plus-init branch May 1, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovesh lovesh lovesh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olegnn @lovesh