Replace `usize` with `u32` in serialized/deserialized structs to avoid cross-platform issues #17

olegnn · 2023-08-24T16:36:12Z

No description provided.

lovesh · 2023-08-24T21:17:41Z

bbs_plus/src/threshold/multiplication_phase.rs

@@ -27,7 +27,7 @@ use oblivious_transfer_protocols::{
 pub struct Phase2<F: PrimeField, const KAPPA: u16, const STATISTICAL_SECURITY_PARAMETER: u16> {
    pub id: ParticipantId,
    /// Number of threshold signatures being generated in a single batch.
-    pub batch_size: usize,
+    pub batch_size: u64,


u16 or u32 would be enough.

lovesh · 2023-08-24T21:18:06Z

bbs_plus/src/threshold/randomness_generation_phase.rs

@@ -14,7 +14,7 @@ use oblivious_transfer_protocols::ParticipantId;
 pub struct Phase1<F: PrimeField, const SALT_SIZE: usize> {
    pub id: ParticipantId,
    /// Number of threshold signatures being generated in a single batch.
-    pub batch_size: usize,
+    pub batch_size: u64,


Same comment as above.

lovesh · 2023-08-24T21:19:51Z

compressed_sigma/src/amortized_homomorphism.rs

@@ -21,7 +21,7 @@ use rayon::prelude::*;
 #[derive(Clone, Debug, PartialEq, Eq, CanonicalSerialize, CanonicalDeserialize)]
 pub struct RandomCommitment<G: AffineRepr> {
    /// Maximum size of the witness vectors
-    pub max_size: usize,
+    pub max_size: u64,


u32 is sufficient and update type in init function signature as well.

lovesh · 2023-08-24T21:22:15Z

delegatable_credentials/src/msbm/issuance.rs

@@ -18,7 +18,7 @@ use ark_std::{rand::RngCore, vec::Vec, UniformRand};
 /// of attributes
 #[derive(Clone, Debug)]
 pub struct Credential<E: Pairing> {
-    pub max_attributes_per_commitment: usize,
+    pub max_attributes_per_commitment: u64,


u32 is a good enough upper bound on the number of attributes. Also update type of max_attributes_per_commitment in issue_*

lovesh · 2023-08-24T21:23:31Z

delegatable_credentials/src/msbm/keys.rs

    #[zeroize(skip)]
-    pub max_attributes_per_commitment: usize,
+    pub max_attributes_per_commitment: u64,


Same comment as above regarding number of attributes

lovesh · 2023-08-24T21:46:44Z

delegatable_credentials/src/msbm/issuance.rs

@@ -29,7 +29,7 @@ pub struct Credential<E: Pairing> {
 /// of attributes
 #[derive(Clone, Debug)]
 pub struct CredentialWithoutOpenings<E: Pairing> {
-    pub max_attributes_per_commitment: usize,
+    pub max_attributes_per_commitment: u64,


Same as above

lovesh · 2023-08-24T21:49:53Z

delegatable_credentials/src/msbm/sps_eq_uc_sig.rs

@@ -264,17 +264,17 @@ impl<E: Pairing> Signature<E> {
        ),
        DelegationError,
    > {
-        if update_key.start_index > insert_at_index {
+        if update_key.start_index as usize > insert_at_index {


Update type of user_public_key and max_attributes_per_commitment in Signature::new* accordingly.

lovesh · 2023-08-24T21:53:44Z

oblivious_transfer/src/ot_based_multiplication/dkls19_batch_mul_2p.rs

@@ -90,7 +90,7 @@ pub struct MaskedInputs<F: PrimeField>(#[serde_as(as = "Vec<ArkObjectBytes>")] p
    Clone, Debug, PartialEq, CanonicalSerialize, CanonicalDeserialize, Serialize, Deserialize,
 )]
 pub struct Party1<F: PrimeField, const KAPPA: u16, const STATISTICAL_SECURITY_PARAMETER: u16> {
-    pub batch_size: usize,
+    pub batch_size: u64,


lovesh · 2023-08-24T21:53:49Z

oblivious_transfer/src/ot_based_multiplication/dkls19_batch_mul_2p.rs

@@ -109,7 +109,7 @@ pub struct Party1<F: PrimeField, const KAPPA: u16, const STATISTICAL_SECURITY_PA
    Clone, Debug, PartialEq, CanonicalSerialize, CanonicalDeserialize, Serialize, Deserialize,
 )]
 pub struct Party2<F: PrimeField, const KAPPA: u16, const STATISTICAL_SECURITY_PARAMETER: u16> {
-    pub batch_size: usize,
+    pub batch_size: u64,


lovesh · 2023-08-24T21:57:25Z

oblivious_transfer/src/ot_extensions/alsz_ote.rs

@@ -236,7 +236,7 @@ impl OTExtensionReceiverSetup {

    pub fn decrypt_random(&self, message_size: usize) -> Vec<Message> {


Change message_size to be u32 in decrypt* and encrypt*

lovesh · 2023-08-24T22:11:27Z

Thanks for these changes. Can you please make the following changes

Update message_count to u32 here , here, here, here and here.
Change here and here to u32.
We use this pattern of generating affine or projective elements by hashing with a label and a counter at a few places in the codebase. Can you move it to a macro in utils crate and just use the macro keeping the counter as u32 in the macro.

lovesh · 2023-08-30T12:19:16Z

utils/src/macros.rs

+#[macro_export]
+macro_rules! affine_group_from_slices {
+    ($($arg: expr),+) => {
+        $crate::hashing_utils::affine_group_elem_from_try_and_incr::<_, D>(&$crate::concat_slices!($($arg),+))


The counter should be in this maacro so that there is only 1 place where we convert it to bytes like this

macro_rules! affine_group_from_slices { (label: expr, prefix: expr, counter: expr) => { } }

and use it like affine_group_from_slices!(label, b" : h_", i)

lovesh · 2023-08-30T12:23:53Z

delegatable_credentials/src/msbm/sps_eq_uc_sig.rs

        srs: &SetCommitmentSRS<E>,
    ) -> Result<(Self, Option<UpdateKey<E>>), DelegationError> {
-        let k = commitments.len();
+        let k = commitments


lovesh · 2023-08-30T12:24:25Z

delegatable_credentials/src/msbm/issuance.rs

        update_key: &UpdateKey<E>,
        set_comm_srs: &SetCommitmentSRS<E>,
    ) -> Result<(Self, Option<UpdateKey<E>>), DelegationError> {
        let rho = E::ScalarField::rand(rng);
        let (new_sig, comm, o, new_uk) = self.signature.change_rel(
            attributes.clone(),
-            self.attributes.len(),
+            self.attributes


lovesh · 2023-08-31T14:43:32Z

utils/src/misc.rs

+}
+
+/// Produces an iterator emitting `n` items `u32::to_le_bytes` of the counter starting from zero.
+pub fn n_bytes_iter(n: u32) -> impl_indexed_iter!(<Item = [u8; 4]>) {


n_bytes_iter -> le_bytes_iter

olegnn added 4 commits August 24, 2023 18:30

usize -> u64

4382f89

fmt

262d3e4

Remove unneeded brackets

84481da

Validation tweaks

13e0da0

olegnn force-pushed the usize-to-u64 branch from dc8eefb to 13e0da0 Compare August 24, 2023 16:46

olegnn requested a review from lovesh August 24, 2023 16:51

Change back amortized_response interface

22c2990

olegnn marked this pull request as draft August 24, 2023 21:52

lovesh requested changes Aug 24, 2023

View reviewed changes

olegnn added 3 commits August 25, 2023 14:36

message_count to u32 in coconut, tweaks for utils

cc5fd57

More type replacements

fb09202

fmt

7a0a7b7

olegnn changed the title ~~Replace usize with u64 in serialized/deserialized structs to avoid cross-platform issues~~ Replace usize with u32 in serialized/deserialized structs to avoid cross-platform issues Aug 25, 2023

olegnn added 4 commits August 25, 2023 17:22

More replacements

bb65536

More replacements

e462336

Tweaks

31ccfe9

Tweaks

321f890

olegnn force-pushed the usize-to-u64 branch from df36726 to 321f890 Compare August 25, 2023 16:10

lovesh reviewed Aug 30, 2023

View reviewed changes

olegnn added 2 commits August 30, 2023 17:53

Misc utils

43a1149

u32 in legogroth16

42c535b

olegnn mentioned this pull request Aug 31, 2023

Support for cross-platform tweaks docknetwork/crypto-wasm#11

Merged

Minor tweak

b62db16

lovesh reviewed Aug 31, 2023

View reviewed changes

lovesh approved these changes Aug 31, 2023

View reviewed changes

olegnn added 2 commits August 31, 2023 18:13

Tweaks, simplifications

c0875f4

Bump up versions

6dfa56c

lovesh marked this pull request as ready for review September 1, 2023 08:56

lovesh merged commit c39cafd into main Sep 1, 2023
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace `usize` with `u32` in serialized/deserialized structs to avoid cross-platform issues #17

Replace `usize` with `u32` in serialized/deserialized structs to avoid cross-platform issues #17

olegnn commented Aug 24, 2023

lovesh Aug 24, 2023

lovesh Aug 24, 2023

lovesh Aug 24, 2023

lovesh Aug 24, 2023 •

edited

Loading

lovesh Aug 24, 2023

lovesh Aug 24, 2023

lovesh Aug 24, 2023

lovesh Aug 24, 2023

lovesh Aug 24, 2023

lovesh Aug 24, 2023

lovesh commented Aug 24, 2023 •

edited

Loading

lovesh Aug 30, 2023

lovesh Aug 30, 2023

lovesh Aug 30, 2023

lovesh Aug 31, 2023

		@@ -236,7 +236,7 @@ impl OTExtensionReceiverSetup {

		pub fn decrypt_random(&self, message_size: usize) -> Vec<Message> {

Replace usize with u32 in serialized/deserialized structs to avoid cross-platform issues #17

Replace usize with u32 in serialized/deserialized structs to avoid cross-platform issues #17

Conversation

olegnn commented Aug 24, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lovesh Aug 24, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lovesh commented Aug 24, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Replace `usize` with `u32` in serialized/deserialized structs to avoid cross-platform issues #17

Replace `usize` with `u32` in serialized/deserialized structs to avoid cross-platform issues #17

lovesh Aug 24, 2023 •

edited

Loading

lovesh commented Aug 24, 2023 •

edited

Loading