Fixing FieldBytes and AffineGroupBytes serialization to also work with RMP #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Types that contain fields serialized as
FieldBytes
orAffineGroupBytes
did not properly serialize with serialization crates other thanserde_json
.The first commit here adds a few lines to the serialization tests that check serialization with
rmp_serde
(i.e., a crate where it does not work currently). The errors can be seen there.The second commit changes the implementations of
FieldBytes
andAffineGroupBytes
by implementing them as a generic version of the expansion of serde_conv!. Serializing types with this new implementation now works under bothserde_json
andrmp_serde
.Please consider merging this in order to allow serialization with RMP (and possibly other serialization crates).