Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 19: Updating obsolete directive. #20

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

JDDoesDev
Copy link
Member

Fixes #19

@lmakarov
Copy link
Member

From the nginx docs, it looks like we may just drop http2_max_field_size altogether as the value we set for large_client_header_buffers is the default:

Syntax:	large_client_header_buffers number size;
Default:	large_client_header_buffers 4 8k;
Context:	http, server

@JDDoesDev
Copy link
Member Author

@lmakarov I've updated the PR with the setting removed altogether as suggested.

@JDDoesDev
Copy link
Member Author

This issue seems to be causing the ngnix container to not start correctly because the healthcheck doesn't like the warning that's being output.

When I inspect the container in VSCode I see this:

"Health": {
      "Status": "unhealthy",
      "FailingStreak": 0,
      "Log": [
        {
          "Start": "2022-06-09T15:08:30.453070785Z",
          "End": "2022-06-09T15:08:30.575382056Z",
          "ExitCode": 0,
          "Output": "2022/06/09 15:08:30 [warn] 78808#78808: the \"http2_max_field_size\" directive is obsolete, use the \"large_client_header_buffers\" directive instead in /etc/nginx/nginx.conf:35\nnginx: [warn] the \"http2_max_field_size\" directive is obsolete, use the \"large_client_header_buffers\" directive instead in /etc/nginx/nginx.conf:35\nnginx: the configuration file /etc/nginx/nginx.conf syntax is ok\nnginx: configuration file /etc/nginx/nginx.conf test is successful\n"
        },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Obsolete Directive http2_max_field_size
3 participants