Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports project volume cleanup from docksal#1058 #51

Merged
merged 3 commits into from
Oct 29, 2019
Merged

Ports project volume cleanup from docksal#1058 #51

merged 3 commits into from
Oct 29, 2019

Conversation

lpeabody
Copy link
Sponsor Contributor

Changes

@lpeabody
Copy link
Sponsor Contributor Author

Alternatively, we could replace:

	log "Removing dangling volumes..."
	docker volume prune -f

with:

	log "Removing dangling volumes..."
	docker volume ls -qf dangling=true | xargs -r docker volume rm

bin/proxyctl Outdated Show resolved Hide resolved
Better comment description + link to related moby issue.

Co-Authored-By: Leonid Makarov <leonid.makarov@ffwagency.com>
@lmakarov
Copy link
Member

We cannot use docker volume ls -qf dangling=true | xargs -r docker volume rm due to docksal/docksal#1056. It can only be used as a one-time fix if you know what you are doing.

bin/proxyctl Outdated Show resolved Hide resolved
@lmakarov lmakarov self-assigned this Oct 29, 2019
@lmakarov lmakarov added this to To do in Docksal 1.13.0 via automation Oct 29, 2019
@lmakarov lmakarov self-requested a review October 29, 2019 20:12
@lmakarov lmakarov merged commit 37c4a87 into docksal:develop Oct 29, 2019
Docksal 1.13.0 automation moved this from To do to Done Oct 29, 2019
@lpeabody lpeabody deleted the feature/backport-docksal-1058-volumes branch October 29, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants