Skip to content

Commit

Permalink
Hide disabled option altogether
Browse files Browse the repository at this point in the history
* would prefer tooltip, but for  angular/components#7953
  • Loading branch information
denis-yuen committed Aug 28, 2018
1 parent b6890c8 commit e577fe0
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 14 deletions.
6 changes: 5 additions & 1 deletion src/app/search/map-friendly-values.pipe.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,11 @@ export class MapFriendlyValuesPipe implements PipeTransform {
])],
['source_control_provider.keyword', new Map([
['GITHUB', 'github.com'], ['BITBUCKET', 'bitbucket.org'], ['GITLAB', 'gitlab.com'], ['DOCKSTORE', 'dockstore.org']
])]
])],
['descriptor_tooltip', new Map([
['CWL', 'Common Workflow Language'], ['WDL', 'Workflow Description Language'],
['Nextflow', 'Nextflow coming soon!']
])],
]);

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,12 +114,16 @@ <h4 mat-dialog-title>Register Workflow</h4>
</form>
<form fxLayout="column" fxLayoutAlign="space-evenly stretch" *ngIf="selectedOption?.value == 1" #registerHostedWorkflowForm="ngForm" name="registerHostedWorkflowForm"
(ngSubmit)="registerHostedWorkflow()" novalidate>
<mat-radio-group id="descriptorTypeRadioButtons" position="before" class="w-100 radio-group" [(ngModel)]="hostedWorkflow.descriptorType" name="descriptorTypes"
(change)="radioButtonChange($event)">
<mat-label>Descriptor Type: </mat-label>
<mat-radio-button *ngFor="let descriptorType of (descriptorLanguages$ | async)" [value]="descriptorType.toLowerCase()" [disabled]="descriptorType === 'NFL'">
{{'descriptor_type' | mapFriendlyValue : descriptorType}}
</mat-radio-button>
<mat-radio-group id="descriptorTypeRadioButtons" position="before" class="w-100 radio-group"
[(ngModel)]="hostedWorkflow.descriptorType" name="descriptorTypes"
(change)="radioButtonChange($event)">
<mat-label matTooltip="Nextflow coming soon!">Descriptor Type:</mat-label>
<ng-container *ngFor="let descriptorType of (descriptorLanguages$ | async)">
<mat-radio-button *ngIf="descriptorType !== 'NFL' "matTooltip="{{'descriptor_tooltip' | mapFriendlyValue : descriptorType}}"
[value]="descriptorType.toLowerCase()" [disabled]="descriptorType === 'NFL'">
{{'descriptor_type' | mapFriendlyValue : descriptorType}}
</mat-radio-button>
</ng-container>
</mat-radio-group>
<mat-form-field class="w-100">
<mat-label>Workflow Name</mat-label>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ import { Router } from '@angular/router';
import { BehaviorSubject, Observable } from 'rxjs';
import { finalize } from 'rxjs/operators';

import { DescriptorLanguageService } from './../../shared/entry/descriptor-language.service';
import { StateService } from './../../shared/state.service';
import { HostedService } from './../../shared/swagger/api/hosted.service';
import { MetadataService } from './../../shared/swagger/api/metadata.service';
import { WorkflowsService } from './../../shared/swagger/api/workflows.service';
import { Workflow } from './../../shared/swagger/model/workflow';
import { WorkflowService } from './../../shared/workflow.service';
import { DescriptorLanguageService } from '../../shared/entry/descriptor-language.service';
import { StateService } from '../../shared/state.service';
import { HostedService } from '../../shared/swagger';
import { MetadataService } from '../../shared/swagger';
import { WorkflowsService } from '../../shared/swagger';
import { Workflow } from '../../shared/swagger';
import { WorkflowService } from '../../shared/workflow.service';
import { RegisterWorkflowModalComponent } from './register-workflow-modal.component';

@Injectable()
Expand Down

0 comments on commit e577fe0

Please sign in to comment.