take us up through expected auto RDS updates #4391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4391 +/- ##
=============================================
+ Coverage 69.12% 69.16% +0.03%
Complexity 3661 3661
=============================================
Files 266 266
Lines 15096 15096
Branches 1647 1647
=============================================
+ Hits 10435 10441 +6
+ Misses 3890 3884 -6
Partials 771 771
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Weird, 11.12 is halfway better than develop but worse than 11.8 |
11.10 |
11.9 FFS with JDBC 23 |
denis-yuen
changed the title
|
think bitbucket is having issues (workflow-integration-tests) |
coverbeck
approved these changes
Aug 6, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Depends on whether we figure this out and are still stuck on postgres 11 when dockstore 1.12 comes out. One known unknown, is the testing slowdown actually seen in real life on AWS RDS or is https://ucsc-cgl.atlassian.net/browse/DOCK-1854 just due to the jdbc driver problem? |
garyluu
approved these changes
Aug 9, 2021
kathy-t
approved these changes
Aug 9, 2021
#4347 was only seen locally. I think the verification of #4338 shows there was no regression in prod. I'll try #4347 again using these changes to see if it fixes it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is newer than what aws rds is running (11.10) , companion to #4388
this maintains performance as seen with 11.8 and with JDBC 42.2.19 but this is with JDBC 42.2.23
Note that "Auto minor version upgrade" is on and will automatically take us to 11.12 at some point anyway
pgjdbc/pgjdbc#2180 explains the pain we ran into with JDBC 42.2.21 but doesn't explain the full problem with postgres 12/13
background benchmarking at https://app.slack.com/archives/CEGMXHBHT/p1628280502020200