Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link sharing endpoint and modify community object for automatic DOI creation #21

Merged
merged 12 commits into from
May 28, 2024

Conversation

kathy-t
Copy link
Collaborator

@kathy-t kathy-t commented May 1, 2024

Description
Webservice PR: dockstore/dockstore#5879

This PR adds the POST endpoint for creating shared access links using the description from https://inveniordm.docs.cern.ch/reference/rest_api_drafts_records/#create-an-access-link.

Also modifies the existing DepositMetadata Community object so that the id field is identifier to match the Zenodo API docs. The invenio deposit metadata docs don't have communities listed, but it is in its future directions section. The FAQ section of this post says that it should be backwards compatible.

Review Instructions
See dockstore/dockstore#5879

Issue
SEAB-6371 - link sharing
SEAB-5929 - automatic DOI creation

Security and Privacy

If there are any concerns that require extra attention from the security team, highlight them here.

e.g. Does this change...

  • Any user data we collect, or data location?
  • Access control, authentication or authorization?
  • Encryption features?

no concerns

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@kathy-t kathy-t self-assigned this May 1, 2024
@denis-yuen
Copy link
Member

(security section and review missing, could be blanked in this case I guess)

@kathy-t
Copy link
Collaborator Author

kathy-t commented May 23, 2024

Added a few more access link endpoints for deleting and getting a link. Re-requesting reviews

Copy link
Member

@denis-yuen denis-yuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review instructions ... could be blanked, can be reviewed as part of main ticket

@kathy-t kathy-t merged commit 1fb0bc5 into main May 28, 2024
2 checks passed
@kathy-t kathy-t deleted the feature/link-sharing branch May 28, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants