Make functions returned "real" actions. #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the extra/double mutable object wrapping when passing down from one layer to the next (and avoids requiring extra `(action` wrapping to prevent this).
This was implemented in the normal `(action` helper in emberjs/ember.js#12519.
|
Excellent! LGTM |
|
Looks like Travis finally finished all of @martndemus's jobs 😝 |
|
I'm sorry 🙃 |
|
@homu r+ |
|
📌 Commit 5c0fa72 has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Feb 5, 2016
Make functions returned "real" actions.
This prevents the extra/double mutable object wrapping when passing down from one layer to the next (and avoids requiring extra `(action` wrapping to prevent this).
Given the following:
```hbs
{{! app/templates/route-template.hbs }}
{{parent-component go=(route-action 'foo')}}
```
```hbs
{{! app/templates/components/parent-component.hbs }}
{{child-component go=go}}
```
Prior to this change, `child-component` would get a mutable object in `this.attrs.go` instead of the invokable function (to work around this you would have to continue to wrap with `(action` either via `{{child-component go=(action go)}}` or `{{parent-component go=(action (route-action 'foo'))}}`).
After this change, `this.attrs.go()` Just Works™.
kevinansfield
added a commit
to kevinansfield/Ghost
that referenced
this pull request
Feb 6, 2016
no issue - cleans up passing route closure actions down through components and ensures callbacks are wrapped in the runloop - DockYard/ember-route-action-helper#8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the extra/double mutable object wrapping when passing down from one layer to the next (and avoids requiring extra
(actionwrapping to prevent this).Given the following:
Prior to this change,
child-componentwould get a mutable object inthis.attrs.goinstead of the invokable function (to work around this you would have to continue to wrap with(actioneither via{{child-component go=(action go)}}or{{parent-component go=(action (route-action 'foo'))}}).After this change,
this.attrs.go()Just Works™.