Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'cabal test' after unpacking a tarball. #21

Merged
merged 1 commit into from Sep 11, 2015

Conversation

ethercrow
Copy link
Contributor

@ryanartecona
Copy link
Member

@ethercrow Do you know if the path to that file will be the same after unpacking it as a tarball vs. in development, in this repo? A quick search brought me to this section of Cabal documentation, which suggests I'll need to add some code to the tests to make sure it loads that file from the right place.

Does that sound right to you? I never know how much I can trust cabal docs verbatim.

@ryanartecona
Copy link
Member

Then again, I suppose the best way to test would be to do an sdist and try installing it somewhere else locally.

@ethercrow
Copy link
Contributor Author

I did a sdist, unpacked it and saw that 'cabal test' passed.

@ryanartecona ryanartecona merged commit f46e55b into docopt:master Sep 11, 2015
@ryanartecona
Copy link
Member

I did too, just before you commented :). The note in that linked doc page about Cabal installing data-files into different places on different platforms made me nervous, so in 73416c3 I just went ahead and did the change suggested in the docs. If I cabal install that sdist tarball locally with run-tests: True in a cabal.config, it works just the same whether or not I include the Paths_docopt module and the getDataFileName helper, so I'd rather err on the side of trusting the docs.

The docopt-0.7.0.4 release I just uploaded includes both changes, so let's hope this one goes through without issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants