Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests #191

Merged
merged 1 commit into from May 30, 2014
Merged

Improve tests #191

merged 1 commit into from May 30, 2014

Conversation

dankeder
Copy link
Contributor

This pull request improves Docopt tests. It's now possible to run tests by executing:

python setup.py test

@keleshev
Copy link
Member

Sorry, not a big fan of these changes:

  • python setup.py test will run unittest, not py.test in your case.
  • Since you indented everything under class DocoptTest(unittest.TestCase):, now git blame will only show your single commit for every line in the test file—which makes it harder to figure out when and why each test was introduced.

If you fix these, I'll merge it. I agree that having a uniform way of launching tests (python setup.py test) is superior to what we have now (an assumption that everyone knows how to use py.test).

@dankeder
Copy link
Contributor Author

Ok, I'll try to do something about that.

@dankeder
Copy link
Contributor Author

I have updated the PR - running python setup.py test now uses pytest and I reverted changes to test_docopt.py.

Please let me know if you have any more suggestions.

keleshev added a commit that referenced this pull request May 30, 2014
Make `python setup.py test` run the test-suite
@keleshev keleshev merged commit 8d07789 into docopt:master May 30, 2014
@keleshev
Copy link
Member

Thanks! Looks perfect now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants